fix(client): deduplicate concurrent OAuth refreshes - #2757
Open
CharlesMcMillan wants to merge 1 commit into
Open
fix(client): deduplicate concurrent OAuth refreshes#2757CharlesMcMillan wants to merge 1 commit into
CharlesMcMillan wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: a8335db The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
@claude review |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent 401 handlers that share one OAuth provider now share one in-flight auth flow. This prevents parallel requests from redeeming the same rotating refresh token and invalidating the session.
Authorization-code exchanges and forced reauthorization bypass deduplication because they carry one-time flow state. Different providers still refresh independently.
Fixes #1760.
Supersedes #1813.
Tests
pnpm --filter @modelcontextprotocol/client test— 883 passedpnpm --filter @modelcontextprotocol/client checkbuild:all,typecheck:all, andlint:all